issue #1: GKE cluster using Terraform (first iteration) #4

ThomasCardin · 2023-12-22T20:53:13Z

This pull request represents the initial iteration of migrating our deployment to Kubernetes.

In this PR, you will find:

Deployment of Ingress Nginx
Deployment of Cert-Manager
Deployment of HashiCorp Vault
Deployment of Nachet-Backend
Deployment of Nachet-Frontend
Deployment of Finesse-Backend
Deployment of Finesse-Frontend
Deployment of the kube-prometheus stack with grafana

Additionally, it includes a sample application for testing the Ingress.

What you won't find in this PR:

A way to manage user access for nachet and finesse
Github authentication for Grafana, ArgoCD, Hashicorp Vault
CD and a way to preview deployment
Instrumentation of application

Issues that will be closed:

…ployment

ThomasCardin · 2024-01-05T15:34:15Z

Finesse URL: https://finesse.ninebasetwo.xyz/
Nachet backend URL: https://nachet.ninebasetwo.xyz/

.gitignore

kubernetes/apps/demo/nginx-deployment.yml

kubernetes/apps/finesse/finesse-deployment.yml

kubernetes/apps/nachet/nachet-deployment.yml

kubernetes/system/cert-manager/issuer.yml

kubernetes/system/kube-prometheus-stack/namespace.yml

terraform/gcp-kubernetes-cluster/vault.tf

rngadam

Previously made a number of comments on this PR but I don't see replies or acknowlegement to them. Can you address the comments @ThomasCardin so I can close those conversation threads?

ThomasCardin · 2024-01-16T14:34:46Z

Previously made a number of comments on this PR but I don't see replies or acknowlegement to them. Can you address the comments @ThomasCardin so I can close those conversation threads?

Done

kubernetes/apps/finesse/finesse-backend-deployment.yml

rngadam

three conversations open waiting for follow up

kubernetes/apps/finesse/finesse-backend-deployment.yml

terraform/gcp-kubernetes-cluster/vault.tf

terraform/gcp-kubernetes-cluster/networking.tf

terraform/gcp-kubernetes-cluster/cluster.tf

README.md

rngadam

I'll revisit once the changes are implemented

…ting the develop branch)

ThomasCardin · 2024-02-05T21:07:40Z

I'll revisit once the changes are implemented

@rngadam Do you have time to review. Every requested changes are done

…d anymore

SonOfLope

LGTM

rngadam

submitting some additional comments that I had made on monday but forgot to submit!

rngadam · 2024-02-04T17:01:45Z

.mlc_config.json

@@ -0,0 +1,3 @@
+{
+    "aliveStatusCodes": [999,200,403]
+}


EOF newline missing! also same content about 999 as before. I also don't think we should accept 403 (documentations behind authentication)

kubernetes/apps/demo/nginx-deployment.yml

terraform/gcp-kubernetes-cluster/networking.tf

…-cluster-for-gcp-w-the-ingress-nginx

ThomasCardin · 2024-02-07T14:22:23Z

Linting error from the kubernetes/system/* will be fixed in another issue

issue #1: GKE cluster using Terraform

6fc5018

ThomasCardin linked an issue Dec 22, 2023 that may be closed by this pull request

Create a kubernetes cluster for GCP (first iteration) #1

Closed

7 tasks

ThomasCardin self-assigned this Dec 22, 2023

ThomasCardin marked this pull request as draft December 22, 2023 20:53

ThomasCardin mentioned this pull request Dec 22, 2023

Create a kubernetes cluster for GCP (first iteration) #1

Closed

7 tasks

ThomasCardin added 5 commits January 3, 2024 15:25

issue #1: Added vault to manage secrets

2c8d565

issue #1: removed aws and azure provider it doesnt belong to this issue

7dd8399

issue #1: removed unused cluster node pool

cb82279

issue #1: nachet-backend kubernetes deployment

4d9ed24

issue #1: added namespace to sa inside nachet deployment + finesse de…

31b1d44

…ployment

ThomasCardin requested a review from rngadam January 5, 2024 15:27

ThomasCardin changed the title ~~issue #1: GKE cluster using Terraform~~ issue #1: GKE cluster using Terraform (first iteration) Jan 5, 2024

ThomasCardin marked this pull request as ready for review January 5, 2024 15:44

ThomasCardin added 2 commits January 8, 2024 13:33

increse proxy-read-timeout to 30m

6385349

issue #1: kube-prometheus-stack (Prometheus, grafana and alertmanager)

d49b0d5

rngadam suggested changes Jan 11, 2024

View reviewed changes

issue #1: Nachet deployment, with backend and frontend

e1f5807

rngadam suggested changes Jan 15, 2024

View reviewed changes

ThomasCardin added 3 commits January 15, 2024 11:11

issue #1: updated the nachet backend image

9a13373

issue #1: fixed both ingress name for nachet

f4f98e4

issue #1: finesse frontend and backend deployed with our images from GCR

e7883a4

ThomasCardin mentioned this pull request Jan 15, 2024

Create a kubernetes cluster for Azure #3

Closed

6 tasks

ThomasCardin added 2 commits January 16, 2024 09:44

issue #1: reviewed and added EOF on files

826e1b9

issue #1: added new version to finesse-frontend

e07aad8

rngadam suggested changes Jan 17, 2024

View reviewed changes

kubernetes/apps/finesse/finesse-backend-deployment.yml Outdated Show resolved Hide resolved

ThomasCardin added 3 commits January 17, 2024 09:54

issue #1: added github workflow

96ed032

issue #1: adding the workflow to the right folder

e2d6231

issue #1: fixed md max line length

91917a4

ThomasCardin added 5 commits January 17, 2024 10:26

issue #1: testing the workflow repo standard with applied patch

8267004

issue #1: removed testing branch for repo standard action

1b072b7

issue #1: testing the repo standard with new token

5dc9f1c

issue #1: testing the repo standard with new token

9d363cd

issue #1: EOF for workflow

d7d16f8

rngadam suggested changes Jan 17, 2024

View reviewed changes

kubernetes/apps/finesse/finesse-backend-deployment.yml Outdated Show resolved Hide resolved

ThomasCardin and others added 2 commits January 17, 2024 16:01

issue #1: fixed 413 error from frontend to backend

d5b616e

issue #1: changed nachet images tag for PR number

a0c1546

rngadam suggested changes Jan 22, 2024

View reviewed changes

rngadam suggested changes Jan 25, 2024

View reviewed changes

ThomasCardin added 3 commits January 31, 2024 08:35

issue #1: changed README.md content

3c19f9e

issue #1: removed unused code

de56ac5

issue #1: changed image version for finesse (default is main represen…

01f7948

…ting the develop branch)

ThomasCardin mentioned this pull request Jan 31, 2024

issue #46: Add every useful workflow for this repository ai-cfia/nachet-backend#49

Closed

4 tasks

issue #1: changed default version of nachet-frontend

8f5f250

ThomasCardin added 2 commits February 6, 2024 11:53

deleted the GKE cluster

82ada60

added providers for the GKE cluster. Note: the cluster isn't supporte…

02801c9

…d anymore

SonOfLope approved these changes Feb 6, 2024

View reviewed changes

rngadam approved these changes Feb 6, 2024

View reviewed changes

ThomasCardin added 6 commits February 7, 2024 08:41

Merge remote-tracking branch 'origin/main' into 1-create-a-kubernetes…

4c6f99c

…-cluster-for-gcp-w-the-ingress-nginx

issue #1: fixed EOF and completing the merge from main

a3b942b

issue #1: fixed yaml linting error for nginx deployment

b90a705

issue #1: fixed yaml linting error for nginx deployment

edf3c83

issue #1: fixed yaml linting error for nginx deployment

23f4db3

issue #1: fixed some yaml linting error

b7d1910

ThomasCardin merged commit 4c772aa into main Feb 7, 2024
2 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

issue #1: GKE cluster using Terraform (first iteration) #4

issue #1: GKE cluster using Terraform (first iteration) #4

ThomasCardin commented Dec 22, 2023 •

edited

Loading

ThomasCardin commented Jan 5, 2024 •

edited

Loading

rngadam left a comment

ThomasCardin commented Jan 16, 2024

rngadam left a comment

rngadam left a comment

ThomasCardin commented Feb 5, 2024 •

edited

Loading

SonOfLope left a comment

rngadam left a comment

rngadam Feb 4, 2024

ThomasCardin Feb 7, 2024

ThomasCardin commented Feb 7, 2024

issue #1: GKE cluster using Terraform (first iteration) #4

issue #1: GKE cluster using Terraform (first iteration) #4

Conversation

ThomasCardin commented Dec 22, 2023 • edited Loading

ThomasCardin commented Jan 5, 2024 • edited Loading

rngadam left a comment

Choose a reason for hiding this comment

ThomasCardin commented Jan 16, 2024

rngadam left a comment

Choose a reason for hiding this comment

rngadam left a comment

Choose a reason for hiding this comment

ThomasCardin commented Feb 5, 2024 • edited Loading

SonOfLope left a comment

Choose a reason for hiding this comment

rngadam left a comment

Choose a reason for hiding this comment

rngadam Feb 4, 2024

Choose a reason for hiding this comment

ThomasCardin Feb 7, 2024

Choose a reason for hiding this comment

ThomasCardin commented Feb 7, 2024

ThomasCardin commented Dec 22, 2023 •

edited

Loading

ThomasCardin commented Jan 5, 2024 •

edited

Loading

ThomasCardin commented Feb 5, 2024 •

edited

Loading